[#838] items_count in the get locations REST endpoint is not returning correctly

Bug Reports
,
1

Migrated from Redmine #838 | Author: Binjie Luo
Status: New | Priority: Immediate, there is BUG! | Created: 2022-01-28

I called get locations endpoint from https://user-api-v2.simplybook.me/admin/locations
There are actually 3 locations returned, but items_count under the meta data is 1, is that expected?
{
“data”: [
{
“id”: 1,
“name”: “WHOOP Labs”,
“description”: “

labs 

”,
“picture”: null,
“picture_preview”: null,
“providers”: [
1,
3
],
“address1”: “1325 Boylston Street”,
“address2”: “”,
“phone”: “”,
“city”: “Boston”,
“zip”: “02215”,
“country_id”: “US”,
“is_visible”: true,
“full_address”: “1325 Boylston Street, Boston, 02215, US”
},
{
“id”: 2,
“name”: “WHOOP Labs Austin”,
“description”: “”,
“picture”: null,
“picture_preview”: null,
“providers”: [
3,
2,
4
],
“address1”: “”,
“address2”: “”,
“phone”: “”,
“city”: “Austin”,
“zip”: “73301”,
“country_id”: “US”,
“is_visible”: true,
“full_address”: “Austin, 73301, US”
},
{
“id”: 3,
“name”: “location1”,
“description”: “”,
“picture”: null,
“picture_preview”: null,
“providers”: [
4
],
“address1”: “”,
“address2”: “”,
“phone”: “”,
“city”: “”,
“zip”: “”,
“country_id”: “US”,
“is_visible”: true,
“full_address”: “US”
}
],
“metadata”: {
“items_count”: 1,
“pages_count”: 1,
“page”: 1,
“on_page”: 1
}
}

2

Binjie Luo wrote:

also notice the similar issue for https://user-api-v2.simplybook.me/admin/providers?filter[service_id]=1&page=1&on_page=1
Even though I set the on_page to 1, all records returned in the data field.

3

Dmytro Bondarev wrote:

Hi,
Please note that it contains metadata, but the locations endpoint will return all records.
You can split by pages on your side and cache the result.

The issue with count will be fixed.

4

Binjie Luo wrote:

Hi Dmitry,

Do you mean that no matter what we put on the page and on_page, all records will still be returned? Then just curious what the meta data is for? I am working on getting all entries from the paginated records, if all records are returned for each call, then that will be the all entries.

5

Binjie Luo wrote:

Hi Dmitry,

Do you mean that no matter what we put on the page and on_page, all records will still be returned? Then just curious what the meta data is for? I am working on getting all entries from the paginated records, if all records are returned for each call, then that will be the all entries.

But the get bookings list endpoint is looking fine though. It will only return 3 bookings if the on_page is set to 3.

6

Dmytro Bondarev wrote:

Yes, for locations, providers, services, categories do not have pagination, metadata contains count.

7

Binjie Luo wrote:

Got you!

(Short original content)